Avoid escaping resource group and subscription labels#60
Open
claw0ry wants to merge 1 commit intoPrateekKumarSingh:masterfrom
Open
Avoid escaping resource group and subscription labels#60claw0ry wants to merge 1 commit intoPrateekKumarSingh:masterfrom
claw0ry wants to merge 1 commit intoPrateekKumarSingh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For me it looks like labels in DOT does not have to escape special characters. Im not proficient in DOT language so if theres a reason that labels for resource groups and subscription are escaped, please cancel this PR.
This PR will remove escaping of special characters when setting the label for resource group and subscription. This is the same behaviour that is already implemented for VNET and Subnets (#65 / #88).
I have tested this locally on macOS, and works as expected there with my Azure environment.